Anders Ingemann
012f21f2a9
Merge pull request #495 from andrewbogott/fix-escapes
...
Fix a couple of (presumed) issues with regex escaping.
2019-03-05 22:19:16 +01:00
Andrew Bogott
a5e8aae7b0
Fix a couple of (presumed) issues with regex escaping.
...
In each of these cases we have an un-escaped \n or \t that
gets passed to a regex. That means that the regexes actually
contain tabs or newlines, respectively. After this change
an actual '\t' and '\n' are passed in instead.
I have not tested this! I am writing this patch based on
the assumption that /surely/ the original authors meant
to pass in \t and \n to the regex and not actual tab
or newline characters.
2019-03-05 21:09:13 +00:00
Anders Ingemann
24ac85802d
Merge pull request #494 from andrewbogott/flake8
...
Flake8
2019-03-05 21:39:04 +01:00
Andrew Bogott
43b321ce91
Replace a bunch of \\ escapes with raw strings
...
There are a few cases where changing to a raw string
will change the behavior; I'll address that in a later patch.
2019-03-05 20:05:59 +00:00
Andrew Bogott
b9dda552db
flake8: resolve W605 'invalid escape sequence' warnings
...
This patch scares me since every fix involves adding a character
to a regex. I am /pretty sure/ that this is a no-op but I don't
have the capacity to test this beyond what tox can do.
2019-03-05 19:01:05 +00:00
Andrew Bogott
bfe2d1f3ba
flake8 fixes: correct some indentations
2019-03-05 16:36:11 +00:00
Andrew Bogott
4dcd1e2f6a
tox: disable W504 "Line break occurred after a binary operator"
...
This is a new coding rule, which actively contradicts the previous
pep8 rule, W503 "line break before binary operator". Both rules
are currently in force, which doesn't make a lot of sense.
Until the standards people work this out, I'm arbitrarily choosing
to disable the rule that involes the fewest coding changes.
2019-03-05 16:31:37 +00:00
Anders Ingemann
99bc43bbe9
ansible: Add task that removes the $HOME/.ansible directory on guest
...
If ansible_ssh_user is set through extra_vars, ansible will
create a .ansible directory in the home dir of that user.
However, it will be owned by root, which is not what ansible
will be expecting when it is provision through SSH at a later date.
2018-07-19 16:52:32 +02:00
Anders Ingemann
92a3b5c079
ec2: Fix linter error with len(tags)>0
2018-07-19 13:24:44 +02:00
Anders Ingemann
b451c81348
ec2: Silence both boto & boto3 during bootstrapping
2018-07-19 13:02:16 +02:00
Anders Ingemann
7a845fcd81
ec2: Fix bug with EBS creation when no tags were specified
...
Also make the creation params a little more modular
2018-07-19 13:02:15 +02:00
Anders Ingemann
2d64ddb867
Merge pull request #487 from john-pierce/ec2_extlinux
...
EC2: Only add grub specific tasks if using grub
2018-07-16 16:52:33 +02:00
John Pierce
13f570ffce
EC2: Only add grub specific tasks if using grub
2018-07-15 12:15:14 -05:00
Anders Ingemann
a4f2e1cfdb
ec2: Fix error when credentials fetching fails
...
A missing 'None' default would cover up the issue that the
user has not supplied any credentials for ec2
2018-07-10 15:05:09 +02:00
Anders Ingemann
bbde39e4fc
admin_user: Remove verbose info about how the key is fetched
...
There is no need to reiterate what the user has already specified
in the manifest.
2018-07-10 15:04:03 +02:00
Anders Ingemann
32e8bbcf49
Merge pull request #482 from citypw/patch-1
...
python package json_minify needed
2018-06-26 17:07:58 +02:00
Shawn C
754995aae3
python package json_minify needed
2018-06-26 14:07:15 +08:00
Anders Ingemann
67720d9e4c
Merge pull request #481 from corteva/add-pip3-plugin
...
Added pip3 plugin
2018-06-14 17:36:47 +02:00
Kirk Hansen
ba263e475d
Added pip3_plugin
2018-06-14 10:19:55 -05:00
Kirk Hansen
ad02412b96
Fix stretch ENA install
...
Intel broke the 4.3.4 URL version with their latest push of 4.3.5
2018-06-14 10:18:47 -05:00
Kirk Hansen
8287a64d3a
Update ebsvolume snapshot_created waiter
...
Sometimes AWS takes longer than 10 minutes to create the snapshot. This
gives them 30 minutes to do it.
2018-06-14 10:18:25 -05:00
Anders Ingemann
631c94c649
Merge pull request #468 from vmlintu-nosto/encrypted_ebs
...
Add support for encrypted AMIs
2018-06-14 10:06:17 +02:00
Veli-Matti Lintu
2a741a81bf
Explicitly define None as the default value for missing kms_key_id key
...
in manifest. None should be returned by default, but this makes it
easier to see.
2018-06-14 09:38:36 +03:00
Anders Ingemann
d27e74316c
Merge pull request #479 from vmlintu-nosto/pylint_E1601_fix
...
Fix cloud-init setup broken by pylint changes
2018-06-13 16:37:48 +02:00
Anders Ingemann
2309b9294b
Merge pull request #480 from kevin-olbrich/patch-1
...
add note to manifest docs regarding https repos
2018-06-13 16:35:23 +02:00
Kevin Olbrich
d70e0952b5
add note to manifest docs regarding https repos
2018-06-13 12:50:04 +02:00
Veli-Matti Lintu
68d7ddb307
Commit 701678c9 changes print statements to print functions with end=' '.
...
As the printed strings contain newlines, this causes a space to be written
as the first character of the following line causing them to be indented.
An example config that is broken. Here disabling modules indents all the
other lines of cloud.cfg except the first one causing the username name
setting to fail as it expects indenting to be certain number of spaces.
plugins:
cloud_init:
metadata_sources: Ec2
username: admin
disable_modules:
- locale
- mounts
This commit removes the spaces by specifying end=''.
2018-06-13 13:20:05 +03:00
Veli-Matti Lintu
8e24c5e795
Add support for encrypted AMIs that can be used to launch instances
...
with encrypted boot volume.
2018-06-12 14:21:37 +03:00
Anders Ingemann
2c02e6875a
Merge pull request #446 from vmlintu-nosto/set_ebs_tags
...
Tag ebs volumes when using ec2 provider
2018-06-11 18:19:50 +02:00
Anders Ingemann
7e6a7d4267
Merge pull request #471 from CMeza99/pylint+imports
...
Pylint code clean up
2018-06-07 22:09:33 +02:00
Veli-Matti Lintu
fcd5b5b396
Add tags also to the EBS volumes when they are created. This follows the
...
same functionality as is already in place for snapshots and AMIs.
2018-06-04 16:52:45 +03:00
Anders Ingemann
161c787906
Merge pull request #467 from vitaminmoo/create-disk-dev-dir
...
Create device dirs if they do not exist
2018-05-02 20:30:04 +02:00
Anders Ingemann
b7ac6470b2
Merge pull request #475 from ishkulov/vagrant-libvirt
...
Add libvirt support for vagrant plugin
2018-05-02 20:17:11 +02:00
Anders Ingemann
8125468853
Merge pull request #473 from CMeza99/fix-trusted-keys
...
set permissions for apt gpg pub keys
2018-05-02 20:14:15 +02:00
Ilarion Ishkulov
19c241be2c
Add libvirt support for vagrant plugin
2018-04-29 21:22:54 +03:00
Carlos Meza
7045d11ed6
set permissions for apt gpg pub keys
2018-04-27 14:44:11 -07:00
Anders Ingemann
fee756185d
Merge pull request #472 from JosephKiranBabu/debian-testing
...
Fix issues in building Debian testing images
2018-04-27 11:20:58 +02:00
Joseph Nuthalapati
419a4300f4
Fix issues in building Debian testing images
...
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
2018-04-27 12:02:22 +05:30
Carlos Meza
1ec736038c
pylint E1608(old-octal-literal)
2018-04-09 22:27:43 -07:00
Carlos Meza
43e54d26cc
pylint E1601(print-statement)
2018-04-09 22:27:29 -07:00
Graham Forest
114a069a99
Create device dirs if they do not exist
...
Some build environments (e.g. Google Cloud Container Builder docker
images) don't have enough of a /dev filesystem to have
/dev/disk/by-uuid/ by default. Make them if they don't exist.
2018-03-28 11:01:41 -07:00
Anders Ingemann
a9efdb4bf9
Merge pull request #463 from CMeza99/pylint
...
Add pylint
2018-03-07 19:30:59 +01:00
Carlos Meza
4e1a5922f7
pylint W0621(redefined-outer-name)
2018-02-25 10:27:53 +00:00
Carlos Meza
23ec568d3c
pylint W0703(broad-except)
2018-02-25 09:43:47 +00:00
Carlos Meza
b180f66ef0
pylint E1101(no-member)
2018-02-25 09:34:12 +00:00
Carlos Meza
7c3dac85aa
update pylintrc
2018-02-25 08:41:01 +00:00
Carlos Meza
05abccda0b
pylint R1704(redefined-argument-from-local)
2018-02-25 08:37:24 +00:00
Carlos Meza
4d5732dbd7
pylint R1705(no-else-return)
2018-02-25 08:37:24 +00:00
Carlos Meza
7bdd9bdaa3
add warnings to pylint
2018-02-25 08:37:24 +00:00
Carlos Meza
d4314c64bb
pylint W0235(useless-super-delegation)
2018-02-25 08:37:24 +00:00