Up until now I didn't see the point of using spaces for indentation.
However, the previous commit (a18bec3) was quite eye opening.
Given that python is an indentation aware language, the amount of
mistakes that went unnoticed because tabs and spaces were used
at the same time (tabs for indentation and spaces for alignment)
were unacceptable.
E101,W191 have been re-enable in the tox flake8 checker and
the documentation has been modified accordingly.
The following files have been left as-is:
* bootstrapvz/common/assets/extlinux/extlinux.conf
* bootstrapvz/common/assets/init.d/expand-root
* bootstrapvz/common/assets/init.d/generate-ssh-hostkeys
* bootstrapvz/common/assets/init.d/squeeze/generate-ssh-hostkeys
* bootstrapvz/plugins/docker_daemon/assets/init.d/docker
* bootstrapvz/providers/ec2/assets/bin/growpart
* bootstrapvz/providers/ec2/assets/grub.d/40_custom
* bootstrapvz/providers/ec2/assets/init.d/ec2-get-credentials
* bootstrapvz/providers/ec2/assets/init.d/ec2-run-user-data
* docs/_static/taskoverview.coffee
* docs/_static/taskoverview.less
* tests/unit/subprocess.sh
When creating an image for Azure we see the following error when applying udev.diff:
TypeError: cannot concatenate 'str' and 'file' objects
Resolving this in log_call() I still see the following error:
patch: **** Only garbage was found in the patch input.
So fixing this in providers/azure/tasks/boot.py seems to be the best route.
GCE also gets its own file.
For now, this scales - but we might want to refactor when there is more that just the kernel package we need to choose from
Specify the version in the manifest (system/waagent section)
Add possibility to specify waagent conf file in manifest (system/waagent section)
Update documentation to match changes
Use log_check_call instead of log_call
refactor test on dictionary key
