In each of these cases we have an un-escaped \n or \t that
gets passed to a regex. That means that the regexes actually
contain tabs or newlines, respectively. After this change
an actual '\t' and '\n' are passed in instead.
I have not tested this! I am writing this patch based on
the assumption that /surely/ the original authors meant
to pass in \t and \n to the regex and not actual tab
or newline characters.
This patch scares me since every fix involves adding a character
to a regex. I am /pretty sure/ that this is a no-op but I don't
have the capacity to test this beyond what tox can do.
* fixed an issue where apt sources get written before the
InstallPuppetlabsPC1ReleaseKey task is performed. added a successor
to the task.
* tox is green
* #347 - Fix for debconf validator pointing to wrong file.
* reported in https://github.com/andsens/bootstrap-vz/issues/347
flake8: commands succeeded
congratulations :)
* # development commit
* trying to fix the packages install with a forced apt-update prior to
installing packages. should fix any issues prior to
* # dev commit
* Trying to parse the commands with a chrotted log_check_call
* # dev commit
* "TypeError: sequence item 2: expected string, list found" , trying to
fix this
* # dev commit - changed the way local packages get installed
This commit changes the way local deb packages get installed.
* rationale: a local deb package mostly includes a deb to configure apt,
e.g.: Puppet apt package. Therefore, after a local dep pkg install , apt
should update itself to be able to install packages that come with the
repo's configured from the local deb package. This assumes you install
LOCAL packages (deb files) first (as a rule of thumb) and AFTER the
REMOTE packages (you include other packages by name)
* reverted command plugin tasks code
* # Dev commit - puppet module update
Goal is to install a puppet 4 agent on the bootstrapped image
* limitations: Only for debian Jessie, installs only puppet4
* # Feature improvement - Puppet module
* a new way to install and configure puppet on a debian jessie
* only tested on debian jessie, for now it only installs the PC1 agent
package.
* future endeavors include all mentioned todo's:
* TODO: plugin must be able to install on any debian release
* TODO: plugin must be able to offer choice of distro package or
apt.puppetlabs.com package
* TODO: plugin must be able to select release version package (vanilla
or PC1)
* TODO: plugin must be able to set up a puppet SERVER , puppetDB
optional
* TODO: plugin have proper linting
* TODO: write test cases
* # Derp commit
* added project files in GitIgnore
* # Dev commit
* added release detection and installs appropriate package.
* # derp commit
* removed unnecessary class parameter.
* # derp dev commit
* add predecessor to ensure repo package gets installed BEFORE the
agent.
* # derp fixes commit
* i must use info.manifest.release
* a little bit refactoring
* # derp commit
* fixed correct predecessor
* # feature & derp dev commit
* added feature to install puppet modules with the plugin
* # Version upgrade commit
New puppet plugin module update
* Plugin can select proper debian release package to install
* Plugin can install modules directly from forge.puppetlabs.com
* Updated documentation with working example
* Limitations TL;DR: agent software only, PC1 package only, Absolute
pathing, wheezy/jessie only, assumes production environment for modules.
* Several ugly derp bugs squashed.
* * PR fix commit
* Modified puppet readme file as recommended
* added small description in changelog
https://github.com/andsens/bootstrap-vz/pull/365#discussion_r101378921https://github.com/andsens/bootstrap-vz/pull/365#discussion_r101379039
* # PR fix commit
* Cleaned debugging leftovers
https://github.com/andsens/bootstrap-vz/pull/365#discussion_r101379293
* # PR fix commit
* Removed todo's from code, creating issues on the project issue
tracker.
https://github.com/andsens/bootstrap-vz/pull/365#discussion_r101381742
* # PR fix commit
* Moved EnableAgent task to the bottom as requested
https://github.com/andsens/bootstrap-vz/pull/365#discussion_r101382775
* # PR fix commit
* Removed gitignore file, I have absolutely no idea how that got there.
* # PR fix commit
* Fixed several TOX issues, it's all green now
* #MR-365 - dev commit
* first try at installing agent with sources/key injection
* New tasks in puppet module: AddPuppetlabsPC1SourcesList;
InstallPuppetlabsPC1ReleaseKey
* it does NOT do any checks. it assumes the url is correct.
* #MR-365 - derp commit
* removed some unused code in tasks
* #365 - tox fix commit
* fixed several tox warnings
* #365 - tox fix commit
* missed one line...
* #365 - tox fix commit
* Noticed the nature of the tox warnings of 'undefined name', fixed.
* # 365 - Task order fix commit
* Some tasks had some invalid predecessors defined, removed.
* when running a test manifest, it fails due to 'NO_PUBKEY
7F438280EF8D349F', trying a hacky way to address this
* #365 - Puppet module update - install with source-key combo
* It now properly installs puppet agent package with sources/keys
instead of package
* Tox is green
* Delete .project
* Delete .pydevproject
* #365 - Puppet module update
General puppet module update.
* Fixed several issues discussed in the pull request.
* Tox is all green
* General puppet module update.
* This update allows for the installation of the puppetlabs.com agent VERSION 4 from the official apt.puppetlabs.com repo
* Allows for the installation of puppet modules. Useful for masterless setups.
* Puppet modules you declare in your bootstrap-vz manifest are installed with the --force flag.
Limitations and gotcha's:
* Only works for Debian Wheezy & Jessie.
* The Puppetlabs.com agents are only released for i386 and amd64 architectures.
* If you require the puppet 3.x agent, you should not use this module but add "puppet-agent" into the packages list
* You need to add your own puppet.conf file to fit your needs, this can be easily included in the assets directive.
* Assets path is absolute.
* General puppet module update.
* This update allows for the installation of the puppetlabs.com agent VERSION 4 from the official apt.puppetlabs.com repo
* Allows for the installation of puppet modules. Useful for masterless setups.
* Puppet modules you declare in your bootstrap-vz manifest are installed with the --force flag.
Limitations and gotcha's:
* Only works for Debian Wheezy & Jessie.
* The Puppetlabs.com agents are only released for i386 and amd64 architectures.
* If you require the puppet 3.x agent, you should not use this module but add "puppet-agent" into the packages list
* You need to add your own puppet.conf file to fit your needs, this can be easily included in the assets directive.
* Assets path is absolute.
* #365 - Changed the way trusted keys are fetched.
* @andsens is right, keyrings are better added by injecting them into
the image, removing the need to install package 'ca-certificates'
* * Added new feature: puppet module version can now be included in the
manifest.
* modified manifest-schema to reflect proper module installation
* Updated documentation.
* Example manifest added to demonstrate changes
* @andsens is right, keyrings are better added by injecting them into
the image, removing the need to install package 'ca-certificates'
* Fix several requests
* Example manifest moved to a more suitable location, documentation
changed as well.
* A bit more efficient programming.
* reverted file_copy to it's proper state
Up until now I didn't see the point of using spaces for indentation.
However, the previous commit (a18bec3) was quite eye opening.
Given that python is an indentation aware language, the amount of
mistakes that went unnoticed because tabs and spaces were used
at the same time (tabs for indentation and spaces for alignment)
were unacceptable.
E101,W191 have been re-enable in the tox flake8 checker and
the documentation has been modified accordingly.
The following files have been left as-is:
* bootstrapvz/common/assets/extlinux/extlinux.conf
* bootstrapvz/common/assets/init.d/expand-root
* bootstrapvz/common/assets/init.d/generate-ssh-hostkeys
* bootstrapvz/common/assets/init.d/squeeze/generate-ssh-hostkeys
* bootstrapvz/plugins/docker_daemon/assets/init.d/docker
* bootstrapvz/providers/ec2/assets/bin/growpart
* bootstrapvz/providers/ec2/assets/grub.d/40_custom
* bootstrapvz/providers/ec2/assets/init.d/ec2-get-credentials
* bootstrapvz/providers/ec2/assets/init.d/ec2-run-user-data
* docs/_static/taskoverview.coffee
* docs/_static/taskoverview.less
* tests/unit/subprocess.sh
- GCE provider wasn't including the GCE SetHostname task, without which
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604883 was
preventing the hostname from getting set after reboot.
- During the GCE build, one of the GCE cleaning tasks was trying to run
an apt-get update after the build-time resolv.conf file was removed.
Fix this ordering by moving the network.Remove* tasks to the
system_cleaning phase as they should have been all along, and adding
an appropriate ordering rule for the GCE cleaning task.
- Add the fallback http.debian.net mirror after, not before, our mirror.
- The puppet plugin's ApplyPuppetManifest task specified that it should
run before the network.Remove* tasks within the system_modification
phase. Now that those tasks have been moved to a later phase
(system_cleaning), remove this dependency. I have no puppet manifest
to test this change, but am including it in hopes of avoiding a
breakage there. Hopefully someone who uses puppet can test this or at
least confirm that it's correct.
Change-Id: Ieca97f288f456bab119989f4cbc4c3993a755830
