This is a new coding rule, which actively contradicts the previous
pep8 rule, W503 "line break before binary operator". Both rules
are currently in force, which doesn't make a lot of sense.
Until the standards people work this out, I'm arbitrarily choosing
to disable the rule that involes the fewest coding changes.
This is a workaround for #356
Let's assume they fix this in > 1.5
The exact error is
AttributeError: 'Toctree' object has no attribute 'titles'
I should probably report this...
Up until now I didn't see the point of using spaces for indentation.
However, the previous commit (a18bec3) was quite eye opening.
Given that python is an indentation aware language, the amount of
mistakes that went unnoticed because tabs and spaces were used
at the same time (tabs for indentation and spaces for alignment)
were unacceptable.
E101,W191 have been re-enable in the tox flake8 checker and
the documentation has been modified accordingly.
The following files have been left as-is:
* bootstrapvz/common/assets/extlinux/extlinux.conf
* bootstrapvz/common/assets/init.d/expand-root
* bootstrapvz/common/assets/init.d/generate-ssh-hostkeys
* bootstrapvz/common/assets/init.d/squeeze/generate-ssh-hostkeys
* bootstrapvz/plugins/docker_daemon/assets/init.d/docker
* bootstrapvz/providers/ec2/assets/bin/growpart
* bootstrapvz/providers/ec2/assets/grub.d/40_custom
* bootstrapvz/providers/ec2/assets/init.d/ec2-get-credentials
* bootstrapvz/providers/ec2/assets/init.d/ec2-run-user-data
* docs/_static/taskoverview.coffee
* docs/_static/taskoverview.less
* tests/unit/subprocess.sh
The work consists of three parts:
* Allow for bootstrapping remotely,
this makes it possible to run the tests
on e.g. OSX with VirtualBox installed
* Make bootstrapping a fully automated process
where the manifests can be generated by the tests
and the tests can call the bootstrapper directly in python
* Create a framework wherein instances can be booted up
using the bootstrapped images and subsequently tested
Overview:
1) fixed up .gitignore file to use absolute paths (to project dir).
2) updated tox to run both manifest tests and flake8
3) updated yml file cause NULL for aws credentials causes an error on validation.
4) actually added the tests under tests/integration
DETAILS:
- Apparently a potential security issue with yaml.load vs yaml.safe_load.
Like pickling, yaml.load could result in arbitrary code being run.
- tox.ini file includes the flake8 settings for this project, build spec for 2.7
and line for eventually testing the project.
