kevinheyer/bootstrap-vz
1
0
Fork 0
mirror of https://github.com/kevingruesser/bootstrap-vz.git synced 2025-08-24 07:26:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Better formatting for CONTRIBUTING.rst

Browse source
This commit is contained in:
Anders Ingemann 2015-04-19 17:04:50 +02:00
parent b46858d9fc
commit fe68d20829
1 changed files with 71 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

131
CONTRIBUTING.rst
View file

@ -52,88 +52,97 @@ these guidelines are not rules , they are advice on how to better add
value to the bootstrap-vz codebase. value to the bootstrap-vz codebase.
* **The manifest should always fully describe the resulting image. The The manifest should always fully describe the resulting image
outcome of a bootstrapping process should never depend on settings ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
specified elsewhere.** The outcome of a bootstrapping process should never depend on settings
specified elsewhere.
This allows others to easily reproduce any This allows others to easily reproduce any setup other people are running
setup other people are running and makes it possible to share and makes it possible to share manifests.
manifests. `The official debian EC2 images <https:/aws.amazon.com/marketplace/seller- `The official debian EC2 images`__ for example can be reproduced
profile?id=890be55d-32d8-4bc8-9042-2b4fd83064d5>`__ using the manifests available in the manifest directory of bootstrap-vz.
for example can be reproduced using the manifests available
in the manifest directory of bootstrap-vz.
* **The bootstrapper should always be able to run fully unattended.** __ https:/aws.amazon.com/marketplace/seller-profile?id=890be55d-32d8-4bc8-9042-2b4fd83064d5
For end users, this guideline minimizes the risk of errors. Any The bootstrapper should always be able to run fully unattended
required input would also be in direct conflict with the previous ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
guideline that the manifest should always fully describe the resulting For end users, this guideline minimizes the risk of errors. Any
image. required input would also be in direct conflict with the previous
guideline that the manifest should always fully describe the resulting
image.
Additionally developers may have to run the bootstrap Additionally developers may have to run the bootstrap
process multiple times though, any prompts in the middle of that process multiple times though, any prompts in the middle of that
process may significantly slow down the development speed. process may significantly slow down the development speed.
* **The bootstrapper should only need as much setup as the manifest
requires.**
Having to shuffle specific paths on the host into place The bootstrapper should only need as much setup as the manifest requires
(e.g. ``/target`` has to be created manually) to get the bootstrapper ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
running is going to increase the rate of errors made by users. Having to shuffle specific paths on the host into place
Aim for minimal setup. (e.g. ``/target`` has to be created manually) to get the bootstrapper
running is going to increase the rate of errors made by users.
Aim for minimal setup.
Exceptions are of course things such as the path to Exceptions are of course things such as the path to
the VirtualBox Guest Additions ISO or tools like ``parted`` that the VirtualBox Guest Additions ISO or tools like ``parted`` that
need to be installed on the host. need to be installed on the host.
* **Roll complexity into which tasks are added to the tasklist.**
If a ``run()`` function checks whether it should do any work or simply be Roll complexity into which tasks are added to the tasklist
skipped, consider doing that check in ``resolve_tasks()`` instead and ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
avoid adding that task alltogether. This allows people looking at the If a ``run()`` function checks whether it should do any work or simply be
tasklist in the logfile to determine what work has been performed. If skipped, consider doing that check in ``resolve_tasks()`` instead and
a task says it will modify a file but then bails , a developer may get avoid adding that task alltogether. This allows people looking at the
confused when looking at that file after bootstrapping. He could tasklist in the logfile to determine what work has been performed.
conclude that the file has either been overwritten or that the
search & replace does not work correctly.
* **Control flow should be directed from the task graph.** If a task says it will modify a file but then bails , a developer may get
confused when looking at that file after bootstrapping. He could
conclude that the file has either been overwritten or that the
search & replace does not work correctly.
Avoid creating complicated ``run()`` functions. If necessary, split up
a function into two semantically separate tasks.
This allows other tasks to interleave with the control-flow and add extended Control flow should be directed from the task graph
functionality (e.g. because volume creation and mounting are two ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
separate tasks, `the prebootstrapped plugin Avoid creating complicated ``run()`` functions. If necessary, split up
<bootstrapvz/plugins/prebootstrapped>`__ a function into two semantically separate tasks.
can replace the volume creation task with a task of its own that
creates a volume from a snapshot instead, but still reuse the mount task).
* **Task classes should be treated as decorated run() functions, they This allows other tasks to interleave with the control-flow and add extended
should not have any state** functionality (e.g. because volume creation and mounting are two
separate tasks, `the prebootstrapped plugin
<bootstrapvz/plugins/prebootstrapped>`__
can replace the volume creation task with a task of its own that
creates a volume from a snapshot instead, but still reuse the mount task).
Thats what the BootstrapInformation object is for.
* **Only add stuff to the BootstrapInformation object when really necessary.** Task classes should be treated as decorated run() functions
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tasks should not have any state, thats what the
BootstrapInformation object is for.
This is mainly to avoid clutter. Only add stuff to the BootstrapInformation object when really necessary
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is mainly to avoid clutter.
* **Use a json-schema to check for allowed settings**
The json-schema may be verbose but it keeps the bulk of check work outside the
python code, which is a big plus when it comes to readability. This of
course only applies bas long as the checks are simple. You can of
course fall back to doing the check in python when that solution is
considerably less complex.
* **When invoking external programs, use long options whenever possible** Use a json-schema to check for allowed settings
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The json-schema may be verbose but it keeps the bulk of check work outside the
python code, which is a big plus when it comes to readability.
This only applies bas long as the checks are simple.
You can of course fall back to doing the check in python when that solution is
considerably less complex.
This makes the commands a lot easier to understand, since
the option names usually hint at what they do.
* **When invoking external programs, don't use full paths, rely on ``$PATH``** When invoking external programs, use long options whenever possible
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This makes the commands a lot easier to understand, since
the option names usually hint at what they do.
This increases robustness when executable locations change.
Example: Use ``log_call(['wget', ...])`` instead of ``log_call(['/usr/bin/wget', ...])``. When invoking external programs, don't use full paths, rely on ``$PATH``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This increases robustness when executable locations change.
Example: Use ``log_call(['wget', ...])`` instead of ``log_call(['/usr/bin/wget', ...])``.
Coding style Coding style