kevinheyer/bootstrap-vz
1
0
Fork 0
mirror of https://github.com/kevingruesser/bootstrap-vz.git synced 2025-08-22 18:00:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Comment the usage of log_call()

Browse source 
Add two comments to the InstallGuestAdditions, explaining why its return
code will not be checked with `log_check_call()` or even manually
grabbing the status informed by `log_call()` itself.

Previously discussed on the #55 issue and 43e3d96 commit.
This commit is contained in:
Tiago Ilieve 2014-04-02 11:43:13 -03:00
parent a037acc673
commit c22c6fe69d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
providers/virtualbox/tasks/guest_additions.py
View file

@ -51,9 +51,10 @@ class InstallGuestAdditions(Task):
root.add_mount(guest_additions_path, mount_path, ['-o', 'loop'])
install_script = os.path.join('/', mount_dir, 'VBoxLinuxAdditions.run')
# Don't check the return code of the scripts here, because 1 not necessarily means they have failed
from common.tools import log_call
log_call(['chroot', info.root, install_script, '--nox11'])
# VBoxService process could be running, as it is not affected by DisableDaemonAutostart
log_call(['chroot', info.root, 'service', 'vboxadd-service', 'stop'])
root.remove_mount(mount_path)
os.rmdir(mount_path)