From c1e931df5e802041518c3abce82401b922c0a2a9 Mon Sep 17 00:00:00 2001 From: Anders Ingemann Date: Fri, 13 Sep 2013 01:32:08 +0200 Subject: [PATCH] Fix bug where log_call would not read all lines --- common/tools.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/tools.py b/common/tools.py index 468394c..ca83783 100644 --- a/common/tools.py +++ b/common/tools.py @@ -31,13 +31,11 @@ def log_call(command, stdin=None): ret = select.select(reads, [], []) for fd in ret[0]: if fd == process.stdout.fileno(): - line = process.stdout.readline() - if line != '': + for line in iter(process.stdout.readline, ''): log.debug(line.strip()) stdout.append(line.strip()) if fd == process.stderr.fileno(): - line = process.stderr.readline() - if line != '': + for line in iter(process.stderr.readline, ''): log.error(line.strip()) stderr.append(line.strip()) if process.poll() is not None: