kevinheyer/bootstrap-vz
1
0
Fork 0
mirror of https://github.com/kevingruesser/bootstrap-vz.git synced 2025-08-22 18:00:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do a basic validation of the manifest before accessing it.

Browse source 
This prevents cryptic error messages
This commit is contained in:
Anders Ingemann 2014-07-06 22:27:36 +02:00
parent 34bb45bb00
commit 1dc9ae18db
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
bootstrapvz/base/manifest.py
View file

@ -25,13 +25,21 @@ class Manifest(object):
self.parse()
def load(self):
"""Loads the manifest.
This function not only reads the manifest but also loads the specified provider and plugins.
Once they are loaded, the initialize() function is called on each of them (if it exists).
"""Loads the manifest and performs a basic validation.
This function reads the manifest, loads the specified provider and plugins, and performs
some basic validation of the manifest itself to ensure that the properties
required for initalization are accessible
(otherwise the user would be presented with some cryptic error messages).
Once the provider and plugins are loaded,
the initialize() function is called on each of them (if it exists).
The provider must have an initialize function.
"""
self.data = load_data(self.path)
from . import validate_manifest
# Validate the manifest with the base validation function in __init__
validate_manifest(self.data, self.schema_validator, self.validation_error)
# Get the provider name from the manifest and load the corresponding module
provider_modname = 'bootstrapvz.providers.' + self.data['provider']['name']
log.debug('Loading provider ' + provider_modname)
@ -57,12 +65,9 @@ class Manifest(object):
init()
def validate(self):
"""Validates the manifest using the base, provider and plugin validation functions.
"""Validates the manifest using the provider and plugin validation functions.
Plugins are not required to have a validate_manifest function
"""
from . import validate_manifest
# Validate the manifest with the base validation function in __init__
validate_manifest(self.data, self.schema_validator, self.validation_error)
# Run the provider validation
self.modules['provider'].validate_manifest(self.data, self.schema_validator, self.validation_error)